Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WaitFor for MySql #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

WaitFor for MySql #5705

merged 1 commit into from
Sep 13, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 13, 2024 •
edited by davidfowl
Loading

Description

Adds support for WaitFor for MySql resources.

Contributes to #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-components label Sep 13, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 13, 2024
@mitchdenny mitchdenny self-assigned this Sep 13, 2024
davidfowl
davidfowl reviewed Sep 13, 2024
View reviewed changes
src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs
Comment on lines +58 to +59
var beforeResourceStartedEvent = new BeforeResourceStartedEvent(databaseResource, @event.Services);
await builder.Eventing.PublishAsync(beforeResourceStartedEvent, ct).ConfigureAwait(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is incorrect but we will do a pass.

@davidfowl davidfowl merged commit cb55938 into main Sep 13, 2024
11 checks passed
@davidfowl davidfowl deleted the mitchdenny/waitfor-mysql branch September 13, 2024 16:12
@davidfowl davidfowl mentioned this pull request Sep 13, 2024
Closed
15 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees

@mitchdenny mitchdenny

Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchdenny @davidfowl