Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WaitFor for RabbitMQ #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2024
Merged

WaitFor for RabbitMQ #5718

merged 1 commit into from
Sep 15, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 15, 2024 •
edited by dotnet-policy-service bot
Loading

Description

Adds WaitFor support for RabbitMQ

Related: #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Sep 15, 2024
@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 15, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Sep 15, 2024
@mitchdenny mitchdenny mentioned this pull request Sep 15, 2024
Closed
15 tasks
@davidfowl
Copy link
Member

We gotta disable this repository test. It’s failing all of the PRs

cc @JamesNK @radical

@JamesNK
Copy link
Member

JamesNK commented Sep 15, 2024

@radical How can I view the log output for this test?

@davidfowl
Copy link
Member

I couldn’t find the logs for that test

@JamesNK
Copy link
Member

JamesNK commented Sep 15, 2024

Me neither. The test is setup to write output: #5701

And I can see test output locally:

image

@davidfowl
Copy link
Member

Lets disable it and file an issue, I'd like to unblock these PRs.

@davidfowl
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit 1bba81c into main Sep 15, 2024
11 checks passed
@davidfowl davidfowl deleted the mitchdenny/waitfor-rabbitmq branch September 15, 2024 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees

@mitchdenny mitchdenny

Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @davidfowl @JamesNK