Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WaitFor for Nats #5753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2024
Merged

WaitFor for Nats #5753

merged 3 commits into from
Sep 19, 2024

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Sep 17, 2024 •
edited by dotnet-policy-service bot
Loading

Description

Adds WaitFor support for Nats

Related: #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-components label Sep 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 17, 2024
mitchdenny
mitchdenny reviewed Sep 18, 2024
View reviewed changes
src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs
{
throw new DistributedApplicationException($"ConnectionStringAvailableEvent was published for the '{milvus.Name}' resource but the connection string was null.");
}
var connectionString = await milvus.ConnectionStringExpression.GetValueAsync(ct).ConfigureAwait(false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to NATS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just follow up milvus PR.

@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages nats and removed area-components labels Sep 18, 2024
@mitchdenny mitchdenny mentioned this pull request Sep 18, 2024
Closed
15 tasks
@mitchdenny
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit e834ec2 into dotnet:main Sep 19, 2024
11 checks passed
@Alirexaa Alirexaa deleted the waitfor-nats branch September 19, 2024 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member nats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alirexaa @mitchdenny