Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 12, 2024

Description

Spans have a parent. A span is not allowed reference itself or one of its anscetors as a parent.

Data sent to the dashboard could contain an invalid circular reference. Rendering the bad data in the UI could cause errors. This PR adds validation logic when spans are received to reject the bad data.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK force-pushed the jamesnk/span-loop-validation branch from 6556856 to 63583de Compare October 16, 2024 08:32
@JamesNK JamesNK added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 16, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Oct 16, 2024

I think the changes are too broad to add to 9.0. Can be merged for vnext.

@JamesNK JamesNK force-pushed the jamesnk/span-loop-validation branch from 63583de to dd1ec4d Compare October 21, 2024 01:23
@JamesNK JamesNK removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 21, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Oct 21, 2024

PR feedback addressed.

@JamesNK JamesNK merged commit 5deda3d into main Oct 21, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/span-loop-validation branch October 21, 2024 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants