Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix spans not hidden on expand/collapse #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix spans not hidden on expand/collapse #6394

merged 1 commit into from
Oct 21, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 21, 2024 •
edited by dotnet-policy-service bot
Loading

Description

A FluentUI update changed how data grids are refreshed. The required change to hadn't this wasn't added for expanding/collapsing spans on trace details and it was broken.

Fixes #6393

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK requested review from drewnoakes and adamint October 21, 2024 08:38
@JamesNK
Copy link
Member Author

JamesNK commented Oct 21, 2024

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11437364368

@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Merged
@JamesNK JamesNK merged commit 029a0f7 into main Oct 21, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/collapse-spans branch October 21, 2024 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

@adamint adamint Awaiting requested review from adamint

Assignees
No one assigned
Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand/collapse buttons don't update the trace details table
2 participants
@JamesNK @drewnoakes