Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Oct 21, 2024

Description

Bump version of Microsoft.Extensions.Http.Resilience to current 9.x preview version on nuget.org and update version used by templates to track the same. This will get updated to stable as part of internal dependency flow.

Contributes to #6076

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • n/a
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No
Microsoft Reviewers: Open in CodeFlow

@eerhardt
Copy link
Member

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11449411666

@DamianEdwards
Copy link
Member Author

@joperezr this change needs the new build since dotnet/extensions@eafdf6e went in to dotnet/extensions (with the TFM-split dependencies). The last version available on the dotnet8 feed is from the day before that change went in.

@DamianEdwards
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Member

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11450650541

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@DamianEdwards DamianEdwards enabled auto-merge (squash) October 22, 2024 00:08
@DamianEdwards
Copy link
Member Author

@eerhardt @joperezr the test errors are caused by Aspire.Hosting.Testing depending on Microsoft.Extensions.Configuration.Binder/8.0.2 which causes a package downgrade in test projects targeting net9.0. Do we need to TFM-split the dependencies of Aspire.Hosting.Testing?

@DamianEdwards
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11464527293

@DamianEdwards DamianEdwards merged commit 194b783 into main Oct 22, 2024
9 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards-templates-http-resilience-version branch October 22, 2024 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants