[release/9.1] Avoid setting --port twice for Azure Functions #7686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this purely visual glitch or functional as well? The latter clearly meets bar |
There was no functional bug here, AFAIK. Previously, we would pass the Ensuring that we only pass the IMO, with this one impact/risk are minimal but it's fairly easy to fix so might as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7683 to release/9.1
/cc @captainsafia
Customer Impact
Our custom functions logic too eagerly set the
--portargument if it was already configured in the command line arguments. This update changes the behavior to only set the port argument dynamically if it's not already defined.Testing
Unit testing. Manual validation on Azure Functions playground app.
Risk
Low risk.
--portis typially configured explicitly in the launchSettings by the default templates so the typical scenario is improved.Regression?
No.