Fix arg annotations when running in IDE mode #7711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs:158
- Slicing exe.Spec.Args without verifying its initialization can lead to a null reference exception when executionType is not IDE. Please ensure that exe.Spec.Args is non-null before attempting to slice it.
var callArgs = executionType == ExecutionType.IDE ? exe.Spec.Args : exe.Spec.Args![^(expectedArgs?.Length ?? 0)..];
tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs:121
- [nitpick] The parameter 'executionType' is being compared to ExecutionType.IDE, which may be of a different type than string. Consider aligning the types (for example, by using an enum consistently) to improve clarity and avoid potential type conversion issues.
if (executionType == ExecutionType.IDE)
|
@captainsafia I think this change removes the need for #7683. Can probably revert it after merge. |
adamint
reviewed
Feb 20, 2025
|
/backport to release/9.1 |
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13444068467 |
|
/backport to release/9.1 |
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13446883474 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply behavior from https://github.com/dotnet/aspire/blob/main/docs/specs/IDE-execution.md#launch-profile-processing-project-launch-configuration when displaying args in the dashboard.
Two changes:
project.Spec.Argsis left as null. That wasn't happening but appears to have special behavior according to the IDE execution spec. Maybe something along the toolchain automatically converts an empty array to null?Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):