Only display trace menu option for uninstrumented peer resources #9030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was a regression, hard to test? |
|
Tests added |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors telemetry-related menu construction for dashboard resources by moving test helpers to a dedicated file and adjusting the menu item creation based on whether the resource is instrumented.
- Moved TestOutgoingPeerResolver implementation from TraceTests.cs into its own file for better test organization.
- Updated ResourceMenuItems logic to conditionally include structured logs and metrics based on the telemetry application's instrumentation status.
- Added a new test file to validate the menu items for uninstrumented peer resources.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Dashboard.Tests/TelemetryRepositoryTests/TraceTests.cs | Removed redundant TestOutgoingPeerResolver helper to streamline test code. |
| tests/Aspire.Dashboard.Tests/TelemetryRepositoryTests/TestOutgoingPeerResolver.cs | Introduces a consolidated implementation of TestOutgoingPeerResolver. |
| tests/Aspire.Dashboard.Tests/Model/ResourceMenuItemsTests.cs | Updates tests to validate the updated menu items behavior for both telemetry and uninstrumented peer resources. |
| src/Aspire.Dashboard/Model/ResourceMenuItems.cs | Adjusted logic to conditionally add telemetry menu items based on resource instrumentation status. |
danmoseley
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9015
Display only the trace option for uninstrumented peer resources:
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate