Thanks to visit codestin.com
Credit goes to github.com

Skip to content

H/QPackEncoder overloads accepting Encoding #24448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jul 30, 2020
Merged

H/QPackEncoder overloads accepting Encoding #24448

1 commit merged into from
Jul 30, 2020

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Jul 30, 2020 •
edited by Tratcher
Loading

Adds overloads accepting an Encoding for header values to H/QPackEncoders.

This is a mirror of changes to H/QPackEncoder merged into runtime in dotnet/runtime#39468.

This is following the Shared code readme - if such changes are mirrored automagically, please close this PR.

Fixes #18943

@MihaZupan MihaZupan requested review from Tratcher and a team July 30, 2020 19:01
@Tratcher
Copy link
Member

Tratcher commented Jul 30, 2020 •
edited
Loading

if such changes are mirrored automagically, please close this PR.

For a change like this we want an explicit PR to make sure nothing breaks. Please ensure both PRs are merged on the same day so the automatic mirror tool doesn't run.

@MihaZupan
Copy link
Member Author

MihaZupan commented Jul 30, 2020 •
edited
Loading

The Runtime PR has been merged ~12h ago. I did run the aspnetcore build & tests listed in the readme before.

@Tratcher Tratcher mentioned this pull request Jul 30, 2020
Closed
@Tratcher
Copy link
Member

The Runtime PR has been merged ~12h ago. I did run the aspnetcore build & tests listed in the readme before.

Haha you missed the auto-mirror bot by about 15 minutes. I ran it manually just to confirm. #24449

@Tratcher Tratcher self-assigned this Jul 30, 2020
@ghost
Copy link

ghost commented Jul 30, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 37 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Tratcher Tratcher added this to the 5.0.0-rc1 milestone Jul 30, 2020
@ghost ghost merged commit e3501dd into dotnet:master Jul 30, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync
2 participants
@MihaZupan @Tratcher