Should this be moved to the websocket middleware instead of signalr's websocket transport.

I thought we we're doing to the header in addition to setting a tag on the activity?

@cijothomas I assume this will be sufficient for AI to exclude long-running SigalR requests from regular request statistics?

I thought we we're doing to the header in addition to setting a tag on the activity?

Why?

@cijothomas I assume this will be sufficient for AI to exclude long-running SigalR requests from regular request statistics?

@shirhatti This will help in AI to exclude long-running requests of Signal-R.

@BrennanConroy

• Application insights gets notified on new ASP.NET Core / SignalR request when it enters Microsoft.AspNetCore.Hosting.HostingApplicationDiagnostics.BeginRequest. At this point we create a request telemetry object to track the request.
• When Microsoft.AspNetCore.Hosting.HostingApplicationDiagnostics.RequestEnd is invoked AI gets notified again at this point we update request telemetry with duration and send it to application insights service.

With the current change we have to create and hold the request telemetry in the heap till the RequestEnd is called and drop request telemetry object on the floor. Proposed change will help us suppress the long running requests but there is a perf issue in creating and holding the RequestTelemetry. Is it possible to add HttpContext request header in BeginRequest before start activity is called.

Is it possible to add HttpContext request header in BeginRequest before start activity is called.

That's impossible. StartActivity is called way too early for that

@davidfowl So that I don't have to use DiagnosticsListener, get the HttpContext and then read the response headers. If I'm an instrumentation library I just want to have all the info on the Activity

Also @rajkumar-rangaraj ,we're adding a response header, not a request header 😄

Also @rajkumar-rangaraj ,we're adding a response header, not a request header 😄

Yes. I reviewed it. As I wanted an update in BeginRequest asked for change in request header.

Yes. I reviewed it. As I wanted an update in BeginRequest asked for change in request header.

This isn't possible.

Should this be moved to the websocket middleware instead of signalr's websocket transport.

I thought you might want to make the WebSocket middleware a little more raw. Instrumentation should treat all WebSocket requests as long-running to begin with.

Updated

nit: Fix the PR title 😄