Make RedirectRule honor specified scheme #41745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for the fast response and saving me the time to submit a pull request myself. :-) |
Tratcher
approved these changes
May 19, 2022
|
Updated, thanks for the reviews. This will get merged after the checks pass and should make it into .NET 7 Preview 5. We'll consider this for inclusion in a .NET 6 update as well. |
halter73
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41707
#28903 introduced a behavioral change in
RedirectRulewhere the scheme used in a redirected request overrides the one specified in the redirect configuration.This fixes that so we now honor the scheme specified in the redirect if there is one.