[release/7.0] Remove tagged keys as entries are evicted #43728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie for ask-mode validation |
halter73
reviewed
Sep 3, 2022
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/test/MemoryOutputCacheStoreTests.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/test/MemoryOutputCacheStoreTests.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
|
Hi @sebastienros. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
@Pilchie approval requested. (updated issue template and tag) |
|
@halter73 would love your review since you discovered the bug |
halter73
approved these changes
Sep 9, 2022
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 9, 2022
src/Middleware/OutputCaching/src/Memory/MemoryOutputCacheStore.cs
Outdated
Show resolved
Hide resolved
|
Approved for .NET 7 RC2. |
|
@wtgodbe can you merge? (easier than finding the build team alias) |
1 task
This was referenced Apr 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When output cache entries are evicted, their keys are not removed from the tagged collections. This fixes it by using a post eviction callback.
Customer Impact
Non-breaking. Fixes potential memory leak.
Regression?
Risk
Verification
Packaging changes reviewed?