Fix invalid redirection after 2FA sign-in (#44395) #44435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @vladdy-moses. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
|
|
@vladdy-moses once you add some test coverage to this, we can get this fix into 8.0 |
|
@vladdy-moses Do you think you'll have time to add test coverage to this PR soon? |
|
Fix looks safe enough to take without tests, thanks @vladdy-moses |
HaoK
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid redirection after 2FA sign-in (#44395)
This PR adds new default event handler for 2FA sign-in standard algorithm.
Description
There is a redundant user redirection when error ocurs during 2FA after
IdentityResult.RequiresTwoFactorresult for /Account/Login (or other default) page.Fixes #44395