Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/7.0] Fixing XML documentation issues for Microsoft.AspNetCore.Http.Results' methods #44488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

[release/7.0] Fixing XML documentation issues for Microsoft.AspNetCore.Http.Results' methods #44488

merged 1 commit into from
Nov 4, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 12, 2022 •
edited by brunolins16
Loading

Backport of #44429 to release/7.0

/cc @brunolins16 @xakep139

Fixing XML documentation issues for Microsoft.AspNetCore.Http.Results' methods

Description

Updates some api comments to correctly be processed and show in the Learn Portal

Fixes #44428

Customer Impact

Without the change the documentation is really bad and only include empty bullets.

Eg.:
image

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

The change only updates the API documentation that will reflect in the Learn portal.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-runtime label Oct 12, 2022
@brunolins16 brunolins16 requested a review from a team October 12, 2022 23:32
@brunolins16 brunolins16 added the Servicing-consider Shiproom approval is required for the issue label Oct 14, 2022
@ghost
Copy link

ghost commented Oct 14, 2022

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@adityamandaleeka
Copy link
Member

@danmoseley I assume we can skip shiproom for this since it's just changing doc comments.

@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Oct 20, 2022
@rbhanda rbhanda added this to the 7.0.1 milestone Oct 20, 2022
@danmoseley
Copy link
Member

Approved for 7.0.1 but same question as #44523 (comment).

@sebastienros
Copy link
Member

@wtgodbe Can you remind me (us?) if we can merge PRs that are aimed for 7.0.1?

@wtgodbe
Copy link
Member

wtgodbe commented Oct 25, 2022

@wtgodbe Can you remind me (us?) if we can merge PRs that are aimed for 7.0.1?

Branches are still closed, current plan is to open them on November 1

@brunolins16
Copy link
Member

@dotnet/aspnet-build since branch is open, can someone help me with this.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 2, 2022

since branch is open, can someone help me with this.

7.0 in this repo isn't open yet, there are some issues with the branding PR. We'll merge this once that's resolved

@dougbu dougbu merged commit a79ce19 into release/7.0 Nov 4, 2022
@dougbu dougbu deleted the backport/pr-44429-to-release/7.0 branch November 4, 2022 03:09
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.
9 participants
@adityamandaleeka @danmoseley @sebastienros @wtgodbe @brunolins16 @dougbu @amcasey @rbhanda @xakep139