Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes #48627 NavLink component is active on wrong path #48718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fixes #48627 NavLink component is active on wrong path #48718

merged 2 commits into from
Jun 14, 2023

Conversation

etemi
Copy link
Contributor

@etemi etemi commented Jun 11, 2023 •
edited
Loading

Fixes #48627 NavLink component is active on wrong path

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

The current code just uses char.IsLetterOrDigit to detect separator characters. I added additonal characters to check whether the given character is an unreserved character.

Fixes #48627

@etemi etemi requested a review from a team as a code owner June 11, 2023 20:24
@ghost ghost added area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member labels Jun 11, 2023
@ghost
Copy link

ghost commented Jun 11, 2023

Thanks for your PR, @etemi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@etemi
Copy link
Contributor Author

etemi commented Jun 11, 2023

@dotnet-policy-service agree

@etemi etemi mentioned this pull request Jun 11, 2023
Closed
4 tasks
@mkArtakMSFT
Copy link
Contributor

Thanks for your PR, @etemi.
Looks like you've sent two PRs for the same issue. Should the other one be closed: #48713 ?

@etemi
Copy link
Contributor Author

etemi commented Jun 13, 2023

Hi @mkArtakMSFT

I'm not the author of the other PR. @adanmaftei created the other PR first: #48713
This (my) PR was created later and is a different solution.

So it is up to you to decide if any of the proposed solution fits your needs.
If there should only be one PR per issue feel free to close mine as I created my PR later.

Thanks

@mkArtakMSFT
Copy link
Contributor

Ah, thanks for clarifying. I somehow got lost in the comments and missed the author.

MackinnonBuck
MackinnonBuck approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @etemi!

I've just added some E2E tests to validate the change.

@MackinnonBuck MackinnonBuck merged commit d7cdc21 into dotnet:main Jun 14, 2023
@ghost ghost added this to the 8.0-preview6 milestone Jun 14, 2023
@etemi etemi deleted the issue-48627 branch June 15, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.

Blazor NavLink component is active on wrong path
3 participants
@etemi @mkArtakMSFT @MackinnonBuck