Clean up some custom awaiters #48722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be updated too? |
It could. It wouldn't really improve anything, though. As a micro-optimization, if you changed that and also added a ConfigureAwait to the subsequent await, you might shave a few bytes off of the state machine created for this async method. |
Some appear to be dead code, others can be replaced by use of ConfigureAwaitOptions. I did not replace ones that appeared to be used by signalr client code as well, as that would have required ifdef'ing.
5b9ae69 to
c256a58
Compare
JamesNK
reviewed
Jun 12, 2023
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
Show resolved
Hide resolved
BrennanConroy
approved these changes
Jun 12, 2023
|
@stephentoub Ready to merge? |
|
yup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some appear to be dead code, others can be replaced by use of ConfigureAwaitOptions. I did not replace ones that appeared to be used by signalr client code as well, as that would have required ifdef'ing.