Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add HybridCache public API #55084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Apr 17, 2024
Merged

Add HybridCache public API #55084

merged 34 commits into from
Apr 17, 2024

Conversation

mgravell
Copy link
Contributor

@mgravell mgravell commented Apr 11, 2024 •
edited
Loading

This is the final proposed API for HybridCache (#54647) as discussed #54647

The implementation is a placeholder (that just invokes the backend service every time, i.e. no cache), and exists purely to test (via the tests project) that:

  • the primary service configuration API can be used through code
  • the configuration options are compatible with ConfigurationBinder
  • the primary GetOrCreateAsync APIs can be used through code (in particular with implicit generic typing)
  • it all works on .NET Framework in addition to .NET "current"
  • the serializer API can at least be implemented and configured successfully (not actually used anywhere)

The code incorporates the changes and feedback from #54647

The bits that we anticipate pushing to runtime are in a sub-folder, but are in their intended namespaces.

@mgravell mgravell requested review from halter73 and amcasey April 11, 2024 15:13
@mgravell mgravell requested review from captainsafia, a team and wtgodbe as code owners April 11, 2024 15:13
@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Apr 11, 2024
@mgravell mgravell added api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews feature-caching Includes: StackExchangeRedis and SqlServer distributed caches labels Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot removed the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Apr 11, 2024
@mgravell mgravell added api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews area-runtime and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot removed the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Apr 11, 2024
amcasey
amcasey reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions but it seems generally good to me. @halter73?

BrennanConroy
BrennanConroy reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits about readability and coding conventions we use

Migaroez
Migaroez reviewed Apr 12, 2024
View reviewed changes
Copy link

@Migaroez Migaroez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a typo while reading the reviews
DisableUndelyingData => DisableUnderlyingData

I did not check all references just did a quick find on github

@mgravell
Copy link
Contributor Author

@Migaroez check that you're looking at latest - see 7edddb1

joegoldman2
joegoldman2 reviewed Apr 13, 2024
View reviewed changes
joegoldman2
joegoldman2 reviewed Apr 14, 2024
View reviewed changes
@mgravell mgravell mentioned this pull request Apr 15, 2024
Merged
@mgravell
Copy link
Contributor Author

@halter73 have I addressed all of your concerns?

mgravell and others added 13 commits April 17, 2024 11:18
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
1db2758 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
2945ce0 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
94d9fe1 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
a13e1d3 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
2a77920 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
cee8ddc 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCacheEntryFlags.cs
7989f16 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
49a477f 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCacheEntryOptions.cs
5f8bcb8 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/HybridCache.cs
7b32e0f 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @joegoldman2
Update src/Caching/Hybrid/src/Runtime/IBufferDistributedCache.cs
62b4e6f 
Co-authored-by: joegoldman2 <[email protected]>
@mgravell @BrennanConroy @joegoldman2
Apply suggestions from code review
c6cdeae 
Co-authored-by: Brennan <[email protected]>
Co-authored-by: joegoldman2 <[email protected]>
@mgravell
more PR feedback
d624726
@mgravell
Copy link
Contributor Author

@joegoldman2 thanks for all the great documentation tweaks

@mgravell
Copy link
Contributor Author

All issue feedback has been addressed, and I've invited additional @halter73 - I'm interpreting existing tick plus silence as "fine"; merging; happy to make additional tweaks as required, but would rather hit next preview and then have a break, than not hit the next preview

@mgravell mgravell merged commit 48dd6a9 into main Apr 17, 2024
@mgravell mgravell deleted the marc/hybrid-api branch April 17, 2024 13:29
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 17, 2024
This was referenced Apr 17, 2024
Closed
Open
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy left review comments

@amcasey amcasey amcasey approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

+2 more reviewers

@Migaroez Migaroez Migaroez left review comments

@joegoldman2 joegoldman2 joegoldman2 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-caching Includes: StackExchangeRedis and SqlServer distributed caches
Projects
None yet
Milestone
9.0-preview4
Development

Successfully merging this pull request may close these issues.
5 participants
@mgravell @Migaroez @BrennanConroy @amcasey @joegoldman2