Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Harden schema reference transformer for relative references #59763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Harden schema reference transformer for relative references #59763

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b39954
Harden schema reference transformer for relative references
captainsafia Jan 7, 2025
35df0d6
Apply suggestions from code review
captainsafia Jan 8, 2025
873bda7
Remove uneeded setting
captainsafia Jan 8, 2025
cdc801b
One more cleanup
captainsafia Jan 8, 2025
303b53f
Check for top-level schemas in tests
captainsafia Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove uneeded setting
  • Loading branch information
@captainsafia
captainsafia committed Jan 8, 2025
commit 873bda77e95e78497d576daf902ee3f6932067e5
1 change: 0 additions & 1 deletion ...penApi/test/Microsoft.AspNetCore.OpenApi.Tests/Extensions/OpenApiSchemaExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ public void ValidateCopyOnAllProperties()

modifiedSchema = originalSchema.Clone();
modifiedSchema.Reference = new OpenApiReference { Id = "Another Id", Type = ReferenceType.Schema };
modifiedSchema.Annotations = new Dictionary<string, object> { ["x-schema-id"] = "another value" };
Assert.False(OpenApiSchemaComparer.Instance.Equals(originalSchema, modifiedSchema));
Assert.True(propertyNames.Remove(nameof(OpenApiSchema.Reference)));

Expand Down
3 changes: 2 additions & 1 deletion ...Core.OpenApi.Tests/Transformers/Implementations/OpenApiSchemaReferenceTransformerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@ private class Item

private class LocationContainer
{

public LocationDto Location { get; set; }
}

Expand All @@ -598,5 +599,5 @@ private class ChildObject
public int Id { get; set; }
public required ParentObject Parent { get; set; }
}
#nullable restore
}
#nullable restore
Loading