Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary newline at the end of the webapiaot csproj #61302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sander1095
Copy link
Contributor

@sander1095 sander1095 commented Apr 3, 2025

Remove unnecessary newline at the end of the webapiaot csproj

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

This PR removes a lingering newline at the end of the webapiaot csproj

Description

In #60337 I added OpenAPI support to the dotnet new webapiaot template. This adds the Microsoft.AspNetCore.OpenApi package by default.

I just tested this locally by installing the preview4 build. I saw that the .csproj has an extra newline at the end, before the </project> tag. The dotnet new webapi template doesn't have this, which means this is a bit inconsistent

I removed this extra newline in this PR to ensure both templates behave the same way.

Fixes #59564

This brings the template in line with the `dotnet new webapi` one, where there is no lingering newline at the end of the csproj.
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 3, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 3, 2025
@sander1095
Copy link
Contributor Author

Hi @captainsafia ! Perhaps you can have a quick peek at this 1LOC PR change :)

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 11, 2025
@captainsafia
Copy link
Member

/azp run

@captainsafia captainsafia enabled auto-merge (squash) April 11, 2025 04:33
@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Apr 11, 2025
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sander1095
Copy link
Contributor Author

The failing tests seems to have nothing to do with my changes. I think it's simply a flaky test?

I think a new /azp run is needed.

@captainsafia
Copy link
Member

@wtgodbe Any chance you can use your powers to merge this whitespace change?

@wtgodbe wtgodbe disabled auto-merge April 11, 2025 16:11
@wtgodbe wtgodbe merged commit 87dc32f into dotnet:main Apr 11, 2025
24 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dotnet new webapiaot" should include OpenAPI support
3 participants