-
Notifications
You must be signed in to change notification settings - Fork 10.3k
HttpNavigationManager
no longer uses NavigationException
#61306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Components/Endpoints/src/DependencyInjection/HttpNavigationManager.cs
Outdated
Show resolved
Hide resolved
...testassets/Components.TestServer/RazorComponents/Pages/Routing/SSRRedirectionStreaming.razor
Outdated
Show resolved
Hide resolved
...s/test/testassets/Components.TestServer/RazorComponents/Pages/Routing/RoutingTestCases.razor
Show resolved
Hide resolved
…onents/Pages/Routing/SSRRedirectionStreaming.razor Co-authored-by: Javier Calvarro Nelson <[email protected]>
while new elements are still getting enqueued into the _batchBuilder.ComponentRenderQueue in
We're operating on the shared object in the loop, so we cannot stop PrerenderedRedirection render. PrerenderedRedirection Deque is triggered after OnInitializedAsync but started in a process triggered before OnInitializedAsync , with _rendererIsStopped=false .
My proposal: An alternative (I need your opinion on this, @javiercn): |
Using the "waiting" queue is not an answer - it blocks rendering because most of the render items is added when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I have some minor feedback about the public API, but let's not block on it for preview 4.
I think we also want to capture some concrete behaviors as part of the Renderer tests to make sure we don't regress them in the future, but we don't have to wait on that for this to go in.
Thanks for persevering through this change!
Description
NavigationException
withAppContext
switch. Naming updates are welcome.catch
es it in the places where they are, withoutAppContext
.httpContext
redirection.HttpNavigationManager
) and interactivity SSR (RemoteNavigationManager
) scenarios.Routing test cases
page.Fixes #59451