Move DotNetBuild.props logic into repo #61485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the TargetFrameworkFilter which isn't necessary as defined centrally by Arcade with the same value.
wtgodbe
reviewed
Apr 14, 2025
| @@ -5,7 +5,6 @@ | |||
| <PropertyGroup> | |||
| <GitHubRepositoryName>aspnetcore</GitHubRepositoryName> | |||
| <SourceBuildManagedOnly>true</SourceBuildManagedOnly> | |||
| <SourceBuildTargetFrameworkFilter>netstandard2.0%3bnetstandard2.1%3bnetcoreapp2.1%3bnetcoreapp3.1%3bnet5.0%3bnet6.0%3bnet7.0%3bnet8.0%3bnet9.0%3bnet10.0</SourceBuildTargetFrameworkFilter> | |||
There was a problem hiding this comment.
I remember needing to set this when we updated the TFM to net10.0 to work around it being missing in Arcade or some such - is that workaround no longer needed?
There was a problem hiding this comment.
I think we can drive this centrally from the Arcade/VMR this time when we move to net11.0. It's currently not needed.
wtgodbe
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnetcore/eng/Common.props
Line 17 in 9878dd9
CrossgenOutputproperty condition into the repo.