Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OpenApi] Fix thread static use and write directly to PipeWriter #61700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[OpenApi] Fix thread static use and write directly to PipeWriter #61700

merged 1 commit into from
Apr 28, 2025

Conversation

BrennanConroy
Copy link
Member

MemoryBufferWriter.Get() and Utf8BufferTextWriter.Get() are not supposed to be used in async code due to using [ThreadStatic] internally.

Additionally, we can write directly to the Response.BodyWriter instead of using a temporary via MemoryBufferWriter and avoid calling ToArray().

@BrennanConroy BrennanConroy requested a review from halter73 April 25, 2025 20:14
@BrennanConroy BrennanConroy requested review from captainsafia and a team as code owners April 25, 2025 20:14
@ghost ghost added the area-web-frameworks label Apr 25, 2025
@BrennanConroy BrennanConroy requested a review from Copilot April 25, 2025 20:15
Copilot
Copilot AI reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the OpenAPI endpoint to eliminate the use of thread-static writers in async code and to write directly to Response.BodyWriter, avoiding unnecessary buffering and copying.

  • Removes the use of MemoryBufferWriter and the pool-based Utf8BufferTextWriter
  • Instantiates a new Utf8BufferTextWriter and sets it to write directly to Response.BodyWriter before serializing the document

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2025
Open
3 tasks
@BrennanConroy BrennanConroy merged commit b212eb9 into main Apr 28, 2025
27 checks passed
@BrennanConroy BrennanConroy deleted the brecon/threadstatic branch April 28, 2025 21:22
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@captainsafia captainsafia captainsafia approved these changes

@halter73 halter73 Awaiting requested review from halter73

Assignees
No one assigned
Labels
area-web-frameworks feature-openapi
Projects
None yet
Milestone
10.0-preview5
Development

Successfully merging this pull request may close these issues.
2 participants
@BrennanConroy @captainsafia