[OpenApi] Fix thread static use and write directly to PipeWriter #61700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the OpenAPI endpoint to eliminate the use of thread-static writers in async code and to write directly to Response.BodyWriter, avoiding unnecessary buffering and copying.
- Removes the use of MemoryBufferWriter and the pool-based Utf8BufferTextWriter
- Instantiates a new Utf8BufferTextWriter and sets it to write directly to Response.BodyWriter before serializing the document
3 tasks
captainsafia
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryBufferWriter.Get()andUtf8BufferTextWriter.Get()are not supposed to be used in async code due to using[ThreadStatic]internally.Additionally, we can write directly to the
Response.BodyWriterinstead of using a temporary viaMemoryBufferWriterand avoid callingToArray().