Create a macOS universal binary #313
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
reviewed
Oct 24, 2024
| <_LipoOuputPath>$(PublishDir)\osx-universal\$(AssemblyName)</_LipoOuputPath> | ||
| </PropertyGroup> | ||
|
|
||
| <Exec Command="lipo @(_RidSpecificSingleFile, ' ') -create -output $(_LipoOuputPath)" Condition="$([MSBuild]::IsOSPlatform('OSX'))" /> |
There was a problem hiding this comment.
I don't know if you care, but this won't work if any of these paths have spaces in them.
|
Tested this on a m2 machine and it works as expected: |
|
Don't think we do notarization for this. |
joeloff
reviewed
Oct 29, 2024
| </EmbeddedResource> | ||
| </ItemGroup> | ||
|
|
||
| <Target Name="PublishMacOSUniversalBinary"> |
There was a problem hiding this comment.
I need help making the macOS build call this - it's one of the questions in the issue description :)
There was a problem hiding this comment.
probably here: https://github.com/dotnet/cli-lab/blob/25e91f1d39ad446131c0fe4bc998c5a33e766773/.vsts-ci.yml#L137C1-L144C33
You can tweak the .yml, then push your branch internal to trigger an official build against your branch, that's the only way to verify yaml changes
9aa602d to
9256923
Compare
9256923 to
e0ea109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a target that
lipoto create a universal binary (thanks @rolfbjarne!)Things we need to think about:
cc @joeloff / @marcpopMSFT