This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Convert codeformatter to SDK projects and update to latest dependencies #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates all projects to use the Microsoft.NET.Sdk and PackageReference. This requires MSBuild 15 (VS 2017) so the build script has been updated to locate this.
eerhardt
reviewed
Aug 3, 2018
build.cmd
Outdated
| goto :error | ||
| ) | ||
|
|
||
| for /f "usebackq tokens=*" %%i in (`%VSWHERELOCATION% -latest -products * -requires Microsoft.Component.MSBuild -property installationPath`) do ( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
eerhardt
reviewed
Aug 3, 2018
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="CodeFormatter.exe" target="lib\net45" /> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
What a monster PR! Thanks for doing this @ericstj. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use codeformatter on the latest corefx projects when porting some source over and encountered a few issues.
Those were both due to using old versions of MSBuild and Roslyn respectively. I fixed those and in the process updated the repo to use SDK projects, fixed the tests to pass, and centralized the dependency information to the root of the repository.
This fixes a number of issues. I tried to go through the issue list and mark the ones that seemed fixed and added some regression tests to prove it.
Fixes #272
Fixes #271
Fixes #268
Fixes #262
Fixes #261
Fixes #258
Fixes #256
Fixes #255
Fixes #241