replace IInvocationResult with Action<InvocationContext> #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't anticipate that the concept of a result will go away with the invocation redesign, so this is still a good simplification. |
jonsequitur
approved these changes
Nov 11, 2022
This was referenced Jul 28, 2025
Bump System.CommandLine and System.CommandLine.NamingConventionBinder
rr-wfm/MSBuild.Sdk.SqlProj#769
Open
This was referenced Aug 5, 2025
This was referenced Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1936
@jonsequitur I don't know if redesigned invocation is still going to keep the concept of
IInvocationResult. If not, this PR can be rejected, as it does not make sense to break the customers twice (now by replacing the interface with delegate, and leter when we remove the delegate too)