This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Improve Math.DivRem performance #8125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion at https://github.com/dotnet/coreclr/issues/3439, this PR at least temporarily changes the implementation of Math.DivRem to avoid two idiv instructions. It then replaces a few % and / pairs in mscorlib with Math.DivRem.
Perf test:
outputs for me:
cc: @jkotas, @mikedn, @redknightlois