This repository was archived by the owner on Jan 23, 2023. It is now read-only.
SslStream Improvements for Unix Performance #22998
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| using System; | ||
| using System.Runtime.InteropServices; | ||
| using Microsoft.Win32.SafeHandles; | ||
| using System.Diagnostics; | ||
|
|
||
| internal static partial class Interop | ||
| { | ||
| internal static partial class Crypto | ||
| { | ||
| internal static class ManagedSslBio | ||
| { | ||
| private unsafe readonly static ReadDelegate s_readDelegate; | ||
| private unsafe readonly static WriteDelegate s_writeDelegate; | ||
|
|
||
| internal static SafeBioHandle CreateManagedSslBio() => Crypto.CreateManagedSslBio(); | ||
|
|
||
| unsafe static ManagedSslBio() | ||
| { | ||
| s_writeDelegate = Write; | ||
| s_readDelegate = Read; | ||
| Crypto.InitManagedSslBioMethod(s_writeDelegate, s_readDelegate); | ||
| } | ||
|
|
||
| internal static void BioSetGCHandle(SafeBioHandle bio, GCHandle handle) | ||
| { | ||
| IntPtr pointer = handle.IsAllocated ? GCHandle.ToIntPtr(handle) : IntPtr.Zero; | ||
| Crypto.BioSetAppData(bio, pointer); | ||
| } | ||
|
|
||
| private static unsafe int Write(IntPtr bio, void* input, int size, IntPtr data) | ||
| { | ||
| GCHandle handle = GCHandle.FromIntPtr(data); | ||
| Debug.Assert(handle.IsAllocated); | ||
|
|
||
| if (handle.Target is SafeSslHandle.WriteBioBuffer buffer) | ||
| { | ||
| return buffer.Write(new Span<byte>(input, size)); | ||
| } | ||
|
|
||
| return -1; | ||
| } | ||
|
|
||
| private static unsafe int Read(IntPtr bio, void* output, int size, IntPtr data) | ||
| { | ||
| GCHandle handle = GCHandle.FromIntPtr(data); | ||
| Debug.Assert(handle.IsAllocated); | ||
|
|
||
| if (handle.Target is SafeSslHandle.ReadBioBuffer buffer) | ||
| { | ||
| return buffer.Read(new Span<byte>(output, size)); | ||
| } | ||
|
|
||
| return -1; | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know this to be always safe? What guarantees does OpenSSL need on the stability of the memory, and what guarantees can we meet with regard to GC compaction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenSsl requires that the memory is the same (as in the content) but that the pointer itself can move. The length must also be the same. So I feel this is fine.
Its really only in place to stop silly mistakes, in this case we know we won't change the content (unless the user is silly enough to modify the input array that is in a method and not returned and modify it else where in another thread). Now it is possible for a user to do this, but then you end up with the same situation as the user doing this while you are mid writing or copying the data anyway.
I do have an idea of how I can possibly remove this, but its not an easy change due to the APM model of the SslInternalStream, the large number of callback chaining in there makes state a tough call.