This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enumerable.ToList() Optimization #3429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public List<TResult> ToList() | ||
| { | ||
| var results = new List<TResult>(_source.Count); | ||
| for (int i = 0; i < _source.Count; i++) |
There was a problem hiding this comment.
Count here is an interface call. I'd suggest storing the result into a local and then using the local.
Via a new internal IListProvider<TElement> interface similar to IArrayProvider<TElement> for ToArray().
38234f4 to
4774046
Compare
|
LGTM now. Thanks, Justin. |
stephentoub
added a commit
that referenced
this pull request
Sep 24, 2015
Enumerable.ToList() Optimization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via a new internal
IListProvider<TElement>interface similar toIArrayProvider<TElement>forToArray().