FromBase64Transform.InputBlockSize set to 4 instead of 1 #39599
Conversation
| public int OutputBlockSize => 3; | ||
| public bool CanTransformMultipleBlocks => false; | ||
| public bool CanTransformMultipleBlocks => true; |
There was a problem hiding this comment.
though that means it'll almost never use the stackalloc buffers
(from https://github.com/dotnet/corefx/issues/39583#issuecomment-512854180)
Are there any statistics about the typical inputCount (i.e. stream length on which CryptoStream should operate)? With these numbers the buffers could be tweaked (stackalloc / renting).
If not, I believe the current implementation of stackalloc / renting is still good.
There was a problem hiding this comment.
Are there any statistics about the typical inputCount (i.e. stream length on which CryptoStream should operate)?
Nope.
The numbers I do have: apisof.net reports 1% APIPort usage for FromBase64Transform, and 0.4% for ToBase64Transform (25% CryptoStream)... and RC2 has almost more usage than that (somehow). Convert.ToBase64String(byte[]) has 51.4% usage, and Convert.FromBase64String is 43,8% usage.
So "no idea what the inputs into this are, but it's definitely not the common way of doing Base64".
| public int OutputBlockSize => 3; | ||
| public bool CanTransformMultipleBlocks => false; | ||
| public bool CanTransformMultipleBlocks => true; |
There was a problem hiding this comment.
I'd like to see at least some test have to change as a result of this. Can you add a test that just checks that the block sizes and can-transform match what we want them to be? :)
There was a problem hiding this comment.
Tests are added with 886b05b
| { | ||
| using (var transform = new ToBase64Transform()) | ||
| { | ||
| Assert.False(transform.CanTransformMultipleBlocks); |
There was a problem hiding this comment.
Is ToBase64Transform already effectively implemented as "true" here? (TransformBlock accepting an integer multiple of the input block size, TransformFinalBlock accepting any arbitrary amount of data) Or would flipping it to true actually cause failures?
There was a problem hiding this comment.
Is ToBase64Transform already effectively implemented as "true" here?
No it's not. It just transforms one block at a time.
See also https://github.com/dotnet/corefx/issues/39583#issuecomment-513304310 for this.
Or would flipping it to true actually cause failures?
This test
will fail with these test-data.|
Retriggering CI to see if Windows x86_Release still fails |
|
Triggering again to hopefully get a clean run. |
Fixes https://github.com/dotnet/corefx/issues/39583 and sets
FromBase64Transform.CanTransformMultipleBlocks = true(cf. https://github.com/dotnet/corefx/issues/39583#issuecomment-512854180).