This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Slimmer QueueUserWorkItemCallback #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benaadams, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
@stephentoub Could you please take a look? |
|
LGTM |
| internal sealed class QueueUserWorkItemCallbackDefaultContext : IThreadPoolWorkItem | ||
| { | ||
| [System.Security.SecuritySafeCritical] | ||
| static QueueUserWorkItemCallbackDefaultContext() { } |
There was a problem hiding this comment.
The empty explicit cctor is not needed for CoreRT. Could you please delete the empty explicit ctor here as well as in the regular QueueUserWorkItemCallback?
|
LGTM modulo minor comment. Thank you for porting the fix to CoreRT! |
014566e to
cf4ba39
Compare
jkotas
added a commit
that referenced
this pull request
Feb 16, 2016
Slimmer QueueUserWorkItemCallback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel of dotnet/coreclr#3157