Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for ISOSDacInterface15 - MethodTable enumeration api #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2024
Merged

Add support for ISOSDacInterface15 - MethodTable enumeration api #4767

merged 4 commits into from
Jul 17, 2024

Conversation

davidwrighton
Copy link
Member

  • Support iterating methods from the new ISOSDacInterface15
  • Re-plumb the existing logic as a local implementation of ISOSDacInterface15 on top of apis that have been present for a long time

This is dependent on dotnet/runtime#101580

@davidwrighton
Add support for ISOSDacInterface15
e332209 
- Support iterating methods from the new ISOSDacInterface15
- Re-plumb the existing logic as a local implementation of ISOSDacInterface15 on top of apis that have been present for a long time
@davidwrighton davidwrighton requested a review from a team as a code owner June 28, 2024 18:58
mikem8361
mikem8361 approved these changes Jun 28, 2024
View reviewed changes
@mikem8361
Copy link
Contributor

You have some build errors:

D:\a\_work\1\s\src\SOS\Strike\strike.cpp(1259,38): error C2220: the following warning is treated as an error [D:\a\_work\1\s\artifacts\obj\Windows_NT.x86.Release\src\SOS\Strike\sos.vcxproj]
D:\a\_work\1\s\src\SOS\Strike\strike.cpp(1259,38): warning C4244: 'initializing': conversion from 'CLRDATA_ADDRESS' to 'DWORD_PTR', possible loss of data [D:\a\_work\1\s\artifacts\obj\Windows_NT.x86.Release\src\SOS\Strike\sos.vcxproj]

/Users/runner/work/1/s/src/SOS/Strike/util.cpp:4018:17: error: delete called on non-final 'SOSDacInterface15Simulator::SOSMethodEnum' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor]
                delete this;
                ^

@davidwrighton davidwrighton requested a review from mikem8361 July 17, 2024 14:21
@davidwrighton davidwrighton merged commit 43dfee3 into dotnet:main Jul 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mikem8361 mikem8361 mikem8361 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidwrighton @mikem8361