Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reference assembly parameter names change #20193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 19, 2020

@gewarren gewarren requested a review from a team as a code owner August 19, 2020 20:53
@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 19, 2020
@gewarren gewarren marked this pull request as draft August 19, 2020 21:34
@gewarren gewarren marked this pull request as ready for review August 19, 2020 22:18
@gewarren
Copy link
Contributor Author

gewarren commented Aug 19, 2020

I don't think any API ref updates are needed. I assume if the moniker is 5.0, the new parameter name will show, and if the moniker is 3.1, the old parameter name will show. @mimisasouvanh Is that a correct assumption?

@Anipik Do you think we need to add a note for each API in the API ref docs that a parameter name changed for 5.0?

@gewarren gewarren requested a review from Anipik August 19, 2020 22:20
@Anipik
Copy link
Contributor

Anipik commented Aug 19, 2020

@Anipik Do you think we need to add a note for each API in the API ref docs that a parameter name changed for 5.0?

I think we dont need to mention that parameter name changed in 5.0 in api ref docs but the docs should contain the latest param name

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 2b8d4a8 into dotnet:master Aug 20, 2020
@gewarren gewarren deleted the ref-assemblies branch August 20, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatches for parameter names between reference and implementation assembly
4 participants