Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Breaking change for floating point to int conversions #42451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 4, 2024
Merged

Breaking change for floating point to int conversions #42451

merged 6 commits into from
Sep 4, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 4, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner September 4, 2024 00:48
@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the 🏁 Release: .NET 9 Work items for the .NET 9 release label Sep 4, 2024
BillWagner
BillWagner approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Once @tannergooding agrees, let's :shipit:

tannergooding
tannergooding reviewed Sep 4, 2024
View reviewed changes
tannergooding
tannergooding reviewed Sep 4, 2024
View reviewed changes
@gewarren gewarren merged commit f53fa6b into dotnet:main Sep 4, 2024
8 checks passed
@gewarren gewarren deleted the saturating branch September 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 9 Work items for the .NET 9 release dotnet-fundamentals/svc
Projects
No open projects
dotnet/docs .NET 9 documentation plan
Status: Done
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Scalar and packed floating point to integer conversions
4 participants
@gewarren @BillWagner @tannergooding @dotnet-bot