Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updating docs after .NET10 Application Enricher update #49690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updating docs after .NET10 Application Enricher update #49690

wants to merge 3 commits into from
+97 −5

Conversation

@mariamgerges
Copy link
Contributor

@mariamgerges mariamgerges commented Nov 10, 2025 •
edited by github-actions bot
Loading

Summary

Describe your changes here.

Fixes #49509

Internal previews

📄 File 🔗 Preview link
docs/core/enrichment/application-log-enricher.md Application log enricher
docs/core/enrichment/custom-enricher.md Custom log enricher

@mariamgerges mariamgerges requested a review from a team as a code owner November 10, 2025 11:55
Copilot AI review requested due to automatic review settings November 10, 2025 11:55
@dotnetrepoman dotnetrepoman bot added this to the November 2025 milestone Nov 10, 2025
@mariamgerges mariamgerges requested review from IEvangelist and evgenyfedorov2 and removed request for a team and Copilot November 10, 2025 11:55
Copilot AI review requested due to automatic review settings November 10, 2025 12:03
Copilot AI reviewed Nov 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for static log enrichers and updates the application log enricher documentation to reflect the new .NET 10 API changes. The key changes include introducing the IStaticLogEnricher interface and documenting the transition from AddServiceLogEnricher to AddApplicationLogEnricher.

  • Adds a new section documenting static log enrichers with IStaticLogEnricher interface
  • Updates application log enricher documentation with tabbed sections for .NET 10+ and .NET 9/earlier
  • Replaces references to deprecated AddServiceLogEnricher with new AddApplicationLogEnricher method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docs/core/enrichment/custom-enricher.md Updates heading to include ILogEnricher interface name and adds new section on static log enrichers
docs/core/enrichment/application-log-enricher.md Adds tabbed content to show both .NET 10+ and .NET 9/earlier API usage with deprecation warning

evgenyfedorov2
evgenyfedorov2 approved these changes Nov 11, 2025
View reviewed changes
@IEvangelist
Copy link
Member

IEvangelist commented Nov 11, 2025

One error, otherwise ship it:

Caution

docs/core/enrichment/application-log-enricher.md
Line 84: [Warning] Cross reference not found:
'Microsoft.Extensions.DependencyInjection.ApplicationEnricherServiceCollectionExtensions.AddApplication LogEnricher(Microsoft.Extensions.DependencyInjection.IServiceCollection)'.

@mariamgerges
Copy link
Contributor Author

mariamgerges commented Nov 11, 2025

One error, otherwise ship it:

Caution

docs/core/enrichment/application-log-enricher.md Line 84: [Warning] Cross reference not found: 'Microsoft.Extensions.DependencyInjection.ApplicationEnricherServiceCollectionExtensions.AddApplication LogEnricher(Microsoft.Extensions.DependencyInjection.IServiceCollection)'.

This error is there because the change is not out yet.

@IEvangelist IEvangelist reopened this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

Assignees

No one assigned

Labels

DO NOT MERGE dotnet-fundamentals/svc

Projects

None yet

Milestone

November 2025

Development

Successfully merging this pull request may close these issues.

Update documentation after PR merges

4 participants

@mariamgerges @IEvangelist @evgenyfedorov2