Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[main] Source code updates from dotnet/scenario-tests #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 24, 2025
Merged

[main] Source code updates from dotnet/scenario-tests #182

merged 8 commits into from
Apr 24, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 22, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/scenario-tests

@premun premun mentioned this pull request Apr 22, 2025
Open
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/scenario-tests:

@dotnet/product-construction

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/scenario-tests) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 23, 2025 •
edited
Loading

@dotnet/source-build for the source-build failure

@NikolaMilosavljevic
Copy link
Member

@dotnet/source-build for the source-build failure

Looking...

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Apr 23, 2025 •
edited
Loading

Online source-build is failing. I'm not sure if the following change is related - it did remove dotnet10 feeds: dotnet/scenario-tests#231 @akoeplinger

Sample error:
2025-04-23T09:47:48.5015631Z ##[error]src/scenario-tests/artifacts/obj/generatedtests/SdkTemplateTest_Mvc_FSharp/SdkTemplateTest_Mvc_FSharp.fsproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Build) Unable to find package Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation with version (>= 10.0.0-preview.5.25222.16) 2025-04-23T09:47:48.5020942Z /__w/1/s/src/scenario-tests/artifacts/obj/generatedtests/SdkTemplateTest_Mvc_FSharp/SdkTemplateTest_Mvc_FSharp.fsproj : error NU1102: - Found 189 version(s) in dotnet-public [ Nearest version: 10.0.0-preview.3.25172.1 ] [/__w/1/s/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/Microsoft.DotNet.ScenarioTests.SdkTemplateTests.csproj] [/__w/1/s/repo-projects/scenario-tests.proj]

@NikolaMilosavljevic
Copy link
Member

Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation package is supposed to be produced by aspnetcore but it does not get created in source-build. dotnet10 feed would have provided the package produced by MSFT build. Looking into this some more.

@NikolaMilosavljevic
Copy link
Member

Well, these feeds are needed for correct scenario-tests usage - preparing the change to bring them back.

@ViktorHofer
Copy link
Member

The transport feed shouldn't be required. It wasn't there before Premek's change.

@MichaelSimons
Copy link
Member

The transport feed shouldn't be required. It wasn't there before Premek's change.

+1, only the dotnet10 feed should be needed.

@ViktorHofer ViktorHofer enabled auto-merge (squash) April 24, 2025 06:10
@ViktorHofer ViktorHofer disabled auto-merge April 24, 2025 12:33
@ViktorHofer ViktorHofer enabled auto-merge (squash) April 24, 2025 12:33
@ViktorHofer ViktorHofer merged commit 709947d into main Apr 24, 2025
16 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-5f2bc1c6-3702-406e-9ffd-d2189c0efc7d branch April 24, 2025 12:33
@ViktorHofer ViktorHofer mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @NikolaMilosavljevic @MichaelSimons @akoeplinger