Thanks to visit codestin.com
Credit goes to github.com

Skip to content

simplified return value #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2019
Merged

simplified return value #2021

merged 2 commits into from
Apr 9, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Mar 12, 2019

No description provided.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is an improvement. You can :shipit: when ready.

It would be nice to know what the return value is if the process has exited, though.

@@ -1335,7 +1335,7 @@ drawObj.SaveAs("C:\Drawings\sample.drw")
<param name="Wait">Optional. <see langword="Boolean" />. A value indicating whether the <see langword="Shell" /> function should wait for completion of the program. If <paramref name="Wait" /> is omitted, <see langword="Shell" /> uses <see langword="False" />.</param>
<param name="Timeout">Optional. <see langword="Integer" />. The number of milliseconds to wait for completion if <paramref name="Wait" /> is <see langword="True" />. If <paramref name="Timeout" /> is omitted, <see langword="Shell" /> uses -1, which means there is no timeout and <see langword="Shell" /> does not return until the program finishes. Therefore, if you omit <paramref name="Timeout" /> or set it to -1, it is possible that <see langword="Shell" /> might never return control to your program.</param>
<summary>Runs an executable program and returns an integer containing the program's process ID if it is still running.</summary>
<returns>Runs an executable program and returns an integer containing the program's process ID if it is still running.</returns>
<returns>An integer containing the program's process ID if it is still running.</returns>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mairaw This begs the question of what the return value is if the process has exited. Is it 0?

@mairaw mairaw added the WIP label Mar 12, 2019
@mairaw mairaw self-assigned this Apr 9, 2019
@mairaw mairaw added this to the April 2019 milestone Apr 9, 2019
@mairaw mairaw merged commit dfd7c33 into master Apr 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-4 branch April 9, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants