Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update docs for PropertyManager #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2019
Merged

Update docs for PropertyManager #3035

merged 2 commits into from
Aug 19, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 16, 2019

No description provided.

@mairaw mairaw added area-WinForms Issues or PRs that relate to WinForms. doc-update Update outdated articles 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Aug 16, 2019
@mairaw mairaw added this to the August 2019 milestone Aug 16, 2019
@mairaw mairaw requested a review from RussKie August 16, 2019 09:49
@mairaw mairaw self-assigned this Aug 16, 2019
rpetrusha
rpetrusha approved these changes Aug 16, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I left two questions.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 16, 2019

@merriemcgaw @Tanya-Solyanik do you want to take a look at the changes I made for PropertyManager?

@mairaw mairaw added the waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged label Aug 16, 2019
Tanya-Solyanik
Tanya-Solyanik approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume these changes are motivated by overall doc style changes.

carlossanlop
carlossanlop approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The build passed with no warnings, so this is good to merge.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 19, 2019

Correct @Tanya-Solyanik. This file was part of the changes in PR #2974 but I thought the particular change for this class was not relevant (RussKie@cd75803#diff-1283fb4f83336c047d77c7321c54368c). But I decided to review the class anyway to make sure it was accurate and following style guide rules.

@mairaw mairaw merged commit 7f0b052 into dotnet:master Aug 19, 2019
@mairaw mairaw deleted the PropertyManager branch August 19, 2019 18:41
@mairaw mairaw removed the waiting-on-feedback Indicates PRs that are waiting for feedback from SMEs before they can be merged label Aug 19, 2019
@RussKie RussKie mentioned this pull request Aug 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@rpetrusha rpetrusha rpetrusha approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@RussKie RussKie Awaiting requested review from RussKie

Assignees

@mairaw mairaw

Labels
area-WinForms Issues or PRs that relate to WinForms. 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 doc-update Update outdated articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@mairaw @carlossanlop @rpetrusha @Tanya-Solyanik