Add missing documentation for DSA types #3498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @carlossanlop |
carlossanlop
suggested changes
Nov 14, 2019
There was a problem hiding this comment.
Thanks for making the change, @bartonjs. I left a couple of questions and a couple of nit suggestions for you to consider.
Co-Authored-By: Maira Wenzel <[email protected]> Co-Authored-By: Carlos Sanchez Lopez <[email protected]>
bartonjs
commented
Nov 15, 2019
carlossanlop
approved these changes
Nov 21, 2019
|
@mairaw I'll merge. If we have to change the |
mairaw
approved these changes
Nov 21, 2019
|
There are some warnings here. Please don't merge yet. |
|
I'll take a look at them soon, @mairaw |
| <paramref name="handle" /> is <see cref="F:System.IntPtr.Zero"/>.</exception> | ||
| <exception cref="T:System.Security.Cryptography.CryptographicException"> | ||
| <paramref name="handle"/> is not a valid <c>DSA*</c>.</exception> | ||
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyValue.OpenSslVersion" /> |
There was a problem hiding this comment.
build warning due to malformed DocId.
The SafeEvpPKeyValue class should've been SafeEvpPKeyHandle:
Suggested change
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyValue.OpenSslVersion" /> | |
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyHandle.OpenSslVersion" /> |
| </exception> | ||
| <exception cref="T:System.Security.Cryptography.CryptographicException"> | ||
| <paramref name="parameters"/> does not represent a valid DSA key parameter set.</exception> | ||
| <altmember cref="M:System.Security.Cryptography.DSA.Create(System.Security.Cryptography.DSA.Create(System.Security.Cryptography.DSAParameters)" /> |
There was a problem hiding this comment.
Malformed DocId. There's a Create call inside the Create call. I removed all the similar instances in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.