Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Link to System.Text.Json conceptual docs #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 20, 2019
Merged

Link to System.Text.Json conceptual docs #3502

merged 8 commits into from
Nov 20, 2019

Conversation

tdykstra
Copy link
Contributor

Fixes #3369

@Thraka
Copy link
Contributor

Thraka commented Nov 15, 2019

I think these should be in <remarks> as <summary> is what is shown in intellisense and having a "for more information see ..." is verbose.

@tdykstra
Copy link
Contributor Author

tdykstra commented Nov 15, 2019 •
edited
Loading

[EDIT] @Thraka I put them there to make them more prominent after noting that it's been done that way frequently in the past. but after looking at how it shows up in Intellisense I'll go ahead and move them to Remarks. Thanks for the note.

@tdykstra tdykstra requested a review from Thraka November 15, 2019 18:18
mairaw
mairaw reviewed Nov 15, 2019
View reviewed changes
mairaw
mairaw reviewed Nov 15, 2019
View reviewed changes
mairaw
mairaw reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add an extra line before the end of the markdown section to avoid problems for Loc. We had issues before.

@tdykstra
Copy link
Contributor Author

@mairaw Were all your comments addressed / can the review be marked as approved?

mairaw
mairaw approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few suggestions for you to consider.

@tdykstra tdykstra merged commit c8ee7ad into dotnet:master Nov 20, 2019
@tdykstra tdykstra deleted the stjlinks branch November 20, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@Thraka Thraka Awaiting requested review from Thraka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to conceptual docs from System.Text.Json API ref
3 participants
@tdykstra @Thraka @mairaw