Remove regular expression as validation method #686
Conversation
Regular expressions deprecated as of .Net Framework 4.7.2 and not in any version of .Net Core https://github.com/Microsoft/dotnet/blob/master/Documentation/compatibility/aspnet-472-compat-doc.md https://github.com/dotnet/corefx/blob/v2.1.5/src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/PhoneAttribute.cs
|
ping @chlowell for confirmation. Once you give the OK, I'll merge this. |
|
@BillWagner I'm only on the compat docs because I wrote automation to generate them, I'm not involved with the content. @rpetrusha, what do you think? |
|
Sorry about that. I meant to ping @divega as owner for |
There was a problem hiding this comment.
Thanks for bringing this to our attention, @KyleMit as well as for contributing to our repo. Since this issue concerns validation by multiple types (EmailAddressAttribute, UrlAttribute, and PhoneAttribute), additional information should be added to the documentation for all three types; I'll open an issue to do address this. Until this issue is addressed, the change you've made is a good one, so I'll merge your PR now. The change should be live on docs.microsoft.com in the next day or two.
Using regular expressions for Phone Validation was deprecated as of .Net Framework 4.7.2 and not in any version of .Net Core
Here's the compatability post on removing regex and the default validator in
[Phone]:https://github.com/Microsoft/dotnet/blob/master/Documentation/compatibility/aspnet-472-compat-doc.md
And .NET Core no longer users regular expressions to determine phone number format validity at all (Presumably because of the best practices on Regex and injection/security concerns)
Here's the source code for core without a Regex in sight:
https://github.com/dotnet/corefx/blob/v2.1.5/src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/PhoneAttribute.cs
Not sure if the description can be forked by API version / framework, but it looks like this single file is serving as the doc for both .NET Framework and .NET Core, and seems easier to just remove the regular expression bit as it's certainly incorrect in the case of Core, but if there's a way to version the comments, then let me know in the PR and I can update the commit to seperate by version.