Thanks to visit codestin.com
Credit goes to github.com

Skip to content

System.Action<T1,T2> F# Snippets #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

albert-du
Copy link
Contributor

Summary

Adds F# code snippets for System.Action<T1,T2>. Revises the article to mention F# and link its lambda expression article.

@albert-du albert-du requested a review from a team as a code owner November 19, 2021 01:20
@ghost
Copy link

ghost commented Nov 19, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Nov 19, 2021

Docs Build status updates of commit e514800:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Action2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Action2.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Delegate.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Lambda.fs ✅Succeeded View
xml/System/Action`2.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@albert-du
Copy link
Contributor Author

@baronfel @dsyme last one I promise (sorry for the spam)

@dsyme
Copy link
Contributor

dsyme commented Nov 19, 2021

@baronfel @dsyme last one I promise (sorry for the spam)

Please keep them coming, they are great!!! Do as many as possible!!

Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Marking as approved but please adjust

with _ -> printfn "File write operation failed..."

let concat =
ConcatStrings(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here

Co-Authored-By: Don Syme <[email protected]>
@albert-du
Copy link
Contributor Author

👍

@opbld31
Copy link

opbld31 commented Nov 19, 2021

Docs Build status updates of commit c34a82b:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Action2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Action2.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Delegate.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Action~2/fs/Lambda.fs ✅Succeeded View
xml/System/Action`2.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@albert-du
Copy link
Contributor Author

@BillWagner this should be ready too

@eiriktsarpalis eiriktsarpalis requested review from a team and removed request for a team November 22, 2021 16:08
@eiriktsarpalis eiriktsarpalis added area-System.Runtime area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. and removed area-System.Runtime labels Nov 22, 2021
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @albert-du

I'll :shipit: now.

@BillWagner BillWagner merged commit 012dd08 into dotnet:main Nov 23, 2021
@albert-du albert-du deleted the system.action`2-fsharp-snippets branch January 19, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants