Thanks to visit codestin.com
Credit goes to github.com

Skip to content

System.Attribute F# snippets #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

albert-du
Copy link
Contributor

Adds F# snippets for the Attribute class

@albert-du albert-du requested a review from a team as a code owner December 24, 2021 05:22
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 24, 2021
@opbld32
Copy link

opbld32 commented Dec 24, 2021

Docs Build status updates of commit 7a2b455:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/customattribute.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/hashcode.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/defattr.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/IsDef1FS.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/match.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/equals.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrparam.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrprminh.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/typeid.fs ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@BillWagner BillWagner requested a review from dsyme January 3, 2022 14:59
Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this as approved though I left one small change request

@opbld34
Copy link

opbld34 commented Jan 4, 2022

Docs Build status updates of commit bbc4e22:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/customattribute.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/hashcode.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/defattr.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/IsDef1FS.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/match.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/equals.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrparam.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrprminh.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/typeid.fs ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jeffhandley jeffhandley added area-System.Runtime and removed area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. labels Jan 5, 2022
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @albert-du

I found one more instance of a variable with ' at the end. I made a suggestion for those. Once you accept that suggestion, and the build is clean, I'll :shipit:.

Thanks again for all you're doing here to help us improve!

module' -> ilmodule
@albert-du
Copy link
Contributor Author

@BillWagner variable name changed. module can't be used as it's a reserved F# language keyword. I've used ilmodule instead.

@BillWagner BillWagner enabled auto-merge (squash) January 5, 2022 15:18
@opbld31
Copy link

opbld31 commented Jan 5, 2022

Docs Build status updates of commit e4f2459:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/customattribute.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/AnimalAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/ca5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/GetCustomAttributes/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/GetHashCode/FS/hashcode.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/defattr.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefaultAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/IsDef1FS.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id4.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/IsDefined/FS/id5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/Match/FS/match.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/equals.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.Equals/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrparam.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.GetCustomAttribute/FS/getcustattrprminh.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/fs.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.Attribute.TypeId/FS/typeid.fs ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@BillWagner BillWagner merged commit b004abc into dotnet:main Jan 5, 2022
@albert-du albert-du deleted the system-attribute-fsharp-snippets branch January 19, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants