Thanks to visit codestin.com
Credit goes to github.com

Skip to content

System.Tuple<T1,T2,T3,T4,T5,T6,T7,TRest> F# snippets #8029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

albert-du
Copy link
Contributor

Adds F# snippets for Tuple<T1,T2,T3,T4,T5,T6,T7,TRest>

@opbld32
Copy link

opbld32 commented May 2, 2022

Docs Build status updates of commit 25a7bac:

⚠️ Validation status: warnings

File Status Preview URL Details
[xml/System/Tuple8.xml](https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System/Tuple8.xml) ⚠️Warning View Details
snippets/fsharp/System/Tuple/Overview/example.fs ✅Succeeded View
snippets/fsharp/System/Tuple/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Equals/equals1.fs ✅Succeeded View
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Equals/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Item1/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Item1/item1.fs ✅Succeeded View
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Overview/octuple1.fs ✅Succeeded View
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/System.Collections.IStructuralComparable.CompareTo/compareto1.fs ✅Succeeded View
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/System.Collections.IStructuralComparable.CompareTo/compareto2.fs ✅Succeeded View
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/System.Collections.IStructuralComparable.CompareTo/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/ToString/fs.fsproj ✅Succeeded
snippets/fsharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/ToString/tostring1.fs ✅Succeeded View

[xml/System/Tuple8.xml](https://github.com/dotnet/dotnet-api-docs/blob/main/xml/System/Tuple8.xml)

  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.
  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @albert-du

I've reviewed these changes, and I'll :shipit: now.

@BillWagner BillWagner merged commit bde46e2 into dotnet:main May 2, 2022
@@ -0,0 +1,67 @@
open System
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you forgot the // <Snippet1> tags in the various Item snippets. That's what caused the build warnings. @albert-du @BillWagner

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see that even if you select F#, the C# example is still shown because it can't find the F# snippet.

https://docs.microsoft.com/en-us/dotnet/api/system.tuple-8.item1?view=net-6.0#examples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albert-du Can you make an updated PR, or should I?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops looks like this one fell off my radar a bit, thank you for fixing it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8042 should fix these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants