-
Notifications
You must be signed in to change notification settings - Fork 1.6k
System.Tuple<T1,T2,T3,T4,T5,T6,T7,TRest> F# snippets #8029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Tuple<T1,T2,T3,T4,T5,T6,T7,TRest> F# snippets #8029
Conversation
Docs Build status updates of commit 25a7bac:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @albert-du
I've reviewed these changes, and I'll now.
@@ -0,0 +1,67 @@ | |||
open System |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you forgot the // <Snippet1>
tags in the various Item snippets. That's what caused the build warnings. @albert-du @BillWagner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see that even if you select F#, the C# example is still shown because it can't find the F# snippet.
https://docs.microsoft.com/en-us/dotnet/api/system.tuple-8.item1?view=net-6.0#examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albert-du Can you make an updated PR, or should I?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops looks like this one fell off my radar a bit, thank you for fixing it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8042 should fix these.
Adds F# snippets for Tuple<T1,T2,T3,T4,T5,T6,T7,TRest>