I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

I followed prior art in System.Runtime.InteropServices APIs

I saw your double-L changes above and I don't have any preference either way.

In any case, thanks for the PR, LGTM.

Docs Build status updates of commit 5c7d400:

✅ Validation status: passed

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

• Try searching the docs.microsoft.com contributor guides
• Post your question in the Docs support channel

Docs Build status updates of commit 939a28e:

✅ Validation status: passed

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

• Try searching the docs.microsoft.com contributor guides
• Post your question in the Docs support channel

I'm surprised that these APIs were named with the single-L version of "marshaller". I thought we'd settled on double-L.

I followed prior art in System.Runtime.InteropServices APIs

@pavelsavara "Marshal" with one L is correct. It's "marshalling" and "marshaller" that I'm referring to, and the existing APIs seems to use two L's:

@pavelsavara "Marshal" with one L is correct. It's "marshalling" and "marshaller" that I'm referring to, and the existing APIs seems to use two L's:

So the only offender is JSMarshalerArgument ? Luckily that is EditorBrowsableState.Never

@pavelsavara And JSMarshalerType, which has the same attribute.

Question: Do we want to also filter these from docs.microsoft.com?

Question: Do we want to also filter these from docs.microsoft.com?

Yes all which is EditorBrowsableState.Never, because most of that API is there for code generated by Roslyn compiler.

Perhaps [LibraryImport] infrastructure also has some new APIs which are for Roslyn only too ? @jkoritzinsky

We have some APIs aimed at being used from the generator, but we don't have any EditorBrowsableState.Never ones.