Add Azure DevOps dependencies to mariner fpm image #844
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| # Provides useradd, needed by Azure DevOps | ||
| shadow-utils \ | ||
| # Provides su, needed by Azure DevOps | ||
| util-linux \ |
There was a problem hiding this comment.
What exactly does needed by Azure DevOps mean?
There was a problem hiding this comment.
Azure Devops runs some commands in the container before executing the .yml steps. These prereqs are vaguely mentioned in https://learn.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=azure-devops#linux-based-containers:
USER has access to groupadd and other privileges commands without sudo
There was a problem hiding this comment.
Hmm, I guess I thought the issue I was seeing in ASP.NET was because we explicitly call useradd:
But note we are running the docker build/run ourselves in the pipeline. Not using AzDO's docker capability.
There was a problem hiding this comment.
I see, then I misread the failure. Azure DevOps does something similar, but if you're not using the AzDO container capability, you might actually not need util-linux.
There was a problem hiding this comment.
I'm leaving shadow-utils and util-linux in here because there are other uses of the centos-7-rpmpkg container that this replaces, where they are used directly by AzDO:
- Installer: https://github.com/dotnet/installer/blob/1f21c4d8a87c91da62cdbdaa173ec7235fa20cdc/.vsts-ci.yml#L252
- VMR: https://github.com/dotnet/dotnet/blob/71497e6d61b3e330d0a1d9653b8b8e38ec64d400/src/runtime/eng/pipelines/common/templates/pipeline-with-resources.yml#L82
- runtime: https://github.com/dotnet/runtime/blob/b9df3643c41b89dd211eeef54eb69799ad3b6e4f/eng/pipelines/common/templates/pipeline-with-resources.yml#L98
|
I don't have merge permission - can someone who does please merge? |
Should help with failures ingesting dotnet/runtime#84148 into aspnet: dotnet/aspnetcore#47693.
@eerhardt @agocke @jkoritzinsky PTAL