Revert "Workaround issue where Update Dependencies tool would sometimes overwrite PRs (#6456)" #6465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es overwrite PRs (dotnet#6456)" This reverts commit 5ca09ee.
mthalman
approved these changes
May 30, 2025
lbussell
added a commit
to lbussell/dotnet-docker
that referenced
this pull request
Jun 5, 2025
…es overwrite PRs (dotnet#6456)" (dotnet#6465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ca09ee.
We weren't getting dependency updates. Update-dependencies was generating updates, but it was silently exiting without creating a PR.
Turns out that is because the Microsoft.DotNet.VersionTools..etc..PullRequestCreator class skips all logic if you set
ForceCreate = true.By reverting this we unblock dependency update PRs. For now I can accept that Update-dependencies tool can overwrite the wrong pull request (#6427) will just happen sometimes.
https://github.com/dotnet/arcade/blob/086a1771875b63404b4a710d27250fe384dc2810/src/VersionTools/Microsoft.DotNet.VersionTools/Automation/PullRequestCreator.cs#L80