SQLServer: Support fill factor for index #20634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ralmsdeveloper
commented
Apr 14, 2020
- Resolve SQL Server Index Fill Factor #19147
lajones
suggested changes
Apr 17, 2020
There was a problem hiding this comment.
Can we also add tests:
- in
SqlServerBuilderExtensionsTestsimilar to the existing ones forIncludeProperties(), (here might be a good place to test theArgumentOutOfRangeExceptions I mention below too), and - in
SqlServerModelDifferTest- see the existing tests forIsCreatedOnline. Plus please add a test to make sure that the model differ picks it up if you change only the fillfactor from one valid value to another.
src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.Tests/Design/Internal/SqlServerAnnotationCodeGeneratorTest.cs
Outdated
Show resolved
Hide resolved
lajones
reviewed
Apr 17, 2020
test/EFCore.SqlServer.Tests/Metadata/SqlServerBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
lajones
suggested changes
Apr 17, 2020
23be175 to
6718165
Compare
|
@lajones rebase is done! |
lajones
reviewed
Apr 18, 2020
lajones
reviewed
Apr 18, 2020
test/EFCore.SqlServer.Tests/Metadata/SqlServerBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
lajones
reviewed
Apr 18, 2020
test/EFCore.SqlServer.Tests/Migrations/SqlServerModelDifferTest.cs
Outdated
Show resolved
Hide resolved
lajones
reviewed
Apr 18, 2020
test/EFCore.SqlServer.Tests/Migrations/SqlServerModelDifferTest.cs
Outdated
Show resolved
Hide resolved
lajones
approved these changes
Apr 18, 2020
There was a problem hiding this comment.
Just a few small comments / naming changes and we're good to go. Thanks very much @ralmsdeveloper !
|
This is now merged. Thanks once again @ralmsdeveloper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.