Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Sep 7, 2023

Actual bug was fixed as side effect of JSON metadata changes. Adding tests that were missing.

Resolves #30885

…iew 4

Actual bug was fixed as side effect of JSON metadata changes. Adding tests that were missing.

Resolves #30885
@ghost
Copy link

ghost commented Sep 7, 2023

Hello @maumar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 7, 2023

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

1 similar comment
@ghost
Copy link

ghost commented Sep 7, 2023

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@maumar maumar requested a review from roji September 8, 2023 01:48
@ghost
Copy link

ghost commented Sep 8, 2023

Apologies, while this PR appears ready to be merged, it looks like release/8.0 is a protected branch and I have not been granted permission to perform the merge.

@maumar maumar merged commit 6bc2298 into release/8.0 Sep 8, 2023
@maumar maumar deleted the test30885 branch September 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateOnly/TimeOnly with JSON exceptions in preview 4
2 participants