Cleanup asserts #32968
Merged
Cleanup asserts #32968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Jan 31, 2024
|
consider updating all instances in the repo https://github.com/search?q=repo%3Adotnet%2Fefcore+%22Assert.Equal%28true%2C%22&type=code cc @maumar |
It cannot be replaced in many cases, when the type is not boolean but instead is an |
|
@btecu Thank you for the contribution! |
roji
pushed a commit
to roji/efcore
that referenced
this pull request
Feb 9, 2024
* Cleanup asserts * Assert.True * fixing compilation error --------- Co-authored-by: maumar <[email protected]>
This was referenced Jul 22, 2025
Merged
This was referenced Oct 1, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Assert.Nullinstead ofAssert.Equal(null, ...).